[compiler-rt] r329817 - [cmake] Remove duplicate command line options from build

[Aleksey Shlyapnikov via llvm-commits]

It seems like Android bot is not happy about this change:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-android/builds/9558/steps/build%20android%2Faarch64/logs/stdio

On Wed, Apr 11, 2018 at 7:56 AM, Aaron Smith via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: asmith
> Date: Wed Apr 11 07:56:35 2018
> New Revision: 329817
>
> URL: http://llvm.org/viewvc/llvm-project?rev=329817&view=rev
> Log:
> [cmake] Remove duplicate command line options from build
>
> CMAKE_CXX_FLAGS was added twice to the command line. This causes the
> command
> line options to be doubled which works until it doesn't as not all options
> can be specified twice.
>
> For example,
>
> clang-cl foo.c /GS- /GS- -mllvm -small-loop-cost=1 -mllvm
> -small-loop-cost=1
> clang (LLVM option parsing): for the -small-loop-cost option: may only
> occur zero or one times!
>
> Modified:
>     compiler-rt/trunk/cmake/Modules/AddCompilerRT.cmake
>
> Modified: compiler-rt/trunk/cmake/Modules/AddCompilerRT.cmake
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/
> cmake/Modules/AddCompilerRT.cmake?rev=329817&r1=329816&r2=329817&view=diff
> ============================================================
> ==================
> --- compiler-rt/trunk/cmake/Modules/AddCompilerRT.cmake (original)
> +++ compiler-rt/trunk/cmake/Modules/AddCompilerRT.cmake Wed Apr 11
> 07:56:35 2018
> @@ -63,8 +63,8 @@ function(add_compiler_rt_object_librarie
>        list(REMOVE_ITEM target_flags "-msse3")
>      endif()
>
> -    set_target_compile_flags(${libname}
> -      ${CMAKE_CXX_FLAGS} ${extra_cflags_${libname}} ${target_flags})
> +    set_target_compile_flags(${libname} ${extra_cflags_${libname}}
> ${target_flags})
> +
>      set_property(TARGET ${libname} APPEND PROPERTY
>        COMPILE_DEFINITIONS ${LIB_DEFS})
>      set_target_properties(${libname} PROPERTIES FOLDER "Compiler-RT
> Libraries")
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180411/16fa4d32/attachment.html>