[PATCH] D45024: [DebugInfo] Add DILabel metadata and intrinsic llvm.dbg.label.

[David Blaikie via llvm-commits]

I realize it's non-trivial to keep these all in the same list - but I'd
rather not create a new list only to remove it again later if it can be
helped. What particular issues did you encounter when attempting to use a
single list?

On Wed, Apr 11, 2018 at 7:17 AM Hsiangkai Wang via Phabricator <
reviews at reviews.llvm.org> wrote:

> HsiangKai updated this revision to Diff 142000.
> HsiangKai added a comment.
>
> Add DILabel list to DISubprogram. The new DISubprogram will be
>
> DISubprogram(..., variables: !7, labels: !8)
>
> To maintain all local entities of the function in one list is not trivial
> modification. I think it should not relate to label debugging. The
> refactoring of these lists into one should be another patch.
>
> So, to enable label debugging, I use a separate list to maintain labels in
> the function. I add a test case in https://reviews.llvm.org/D45045 under
> Clang repo.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D45024
>
> Files:
>   include/llvm/Analysis/TargetTransformInfoImpl.h
>   include/llvm/Bitcode/LLVMBitCodes.h
>   include/llvm/IR/DIBuilder.h
>   include/llvm/IR/DebugInfoMetadata.h
>   include/llvm/IR/InstVisitor.h
>   include/llvm/IR/IntrinsicInst.h
>   include/llvm/IR/Intrinsics.td
>   include/llvm/IR/Metadata.def
>   lib/Analysis/ObjCARCInstKind.cpp
>   lib/Analysis/ValueTracking.cpp
>   lib/AsmParser/LLParser.cpp
>   lib/Bitcode/Reader/MetadataLoader.cpp
>   lib/Bitcode/Writer/BitcodeWriter.cpp
>   lib/CodeGen/IntrinsicLowering.cpp
>   lib/IR/AsmWriter.cpp
>   lib/IR/DIBuilder.cpp
>   lib/IR/DebugInfoMetadata.cpp
>   lib/IR/LLVMContextImpl.h
>   lib/IR/Verifier.cpp
>   lib/Transforms/Utils/Local.cpp
>   lib/Transforms/Utils/SimplifyCFG.cpp
>   test/DebugInfo/Generic/debug-label-bitcode.ll
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180411/3414580e/attachment.html>