[PATCH] D45396: [DebugInfo] Create merged locations for instructions other than calls

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 10 18:37:25 PDT 2018


aprantl added a comment.

I'm fine with this change since the result is more accurate than before (where the instruction would inherit whatever the previous instruction's location was.

David: how do you feel about the size increase, since you brought that up?



================
Comment at: include/llvm/IR/DebugInfoMetadata.h:1512
+  /// is true, we will set the merged debug location as line 0 of the nearest
+  /// common scope where 2 locations are inlined from.
+  //
----------------
`... common scope the the two locations.`


https://reviews.llvm.org/D45396





More information about the llvm-commits mailing list