[PATCH] D45473: CodeGen: Don't try to canonicalize Unix-style paths in CodeView debug info.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 10 16:44:43 PDT 2018


pcc added a comment.

In https://reviews.llvm.org/D45473#1063737, @rnk wrote:

> In https://reviews.llvm.org/D45473#1063531, @pcc wrote:
>
> > In https://reviews.llvm.org/D45473#1063321, @rnk wrote:
> >
> > > Can you elaborate on the use case? What tool do you expect will consume these Unix style paths?
> >
> >
> > We can use the paths to provide better linker error messages. See https://reviews.llvm.org/D45467.
>
>
> For this use case, is it actually important to preserve symlinks? Would it be enough to make the linker canonicalize the slashes to native format when printing the diagnostic?


Assuming that we don't care about symlinks, that would work I suppose, but it wouldn't necessarily do the right thing in distributed links, and it would mean that any other tools that consume CodeView on non-Windows (e.g. LLDB remote debugging a Windows binary) would need to do the same thing.


https://reviews.llvm.org/D45473





More information about the llvm-commits mailing list