[PATCH] D45396: [DebugInfo] Create merged locations for instructions other than calls

[Vedant Kumar via Phabricator via llvm-commits]

vsk marked an inline comment as done.
vsk added a comment.

In https://reviews.llvm.org/D45396#1062505, @dblaikie wrote:

> Do you have the stats on this change in terms of line table size increase?


I looked at a stage2 Release build of clang (-O3 -g), and there's about a 0.6% size increase:

  $ size -m ~/Desktop/baseline.clang.dSYM/Contents/Resources/DWARF/clang | grep debug_line 
          Section __debug_line: 34433811
  $ size -m ~/Desktop/after-diloc-patch.clang.dSYM/Contents/Resources/DWARF/clang | grep debug_line 
          Section __debug_line: 34646430



> Which callers use Instruction::applyMergedLocation versus DILocation::getMergedLocation directly?

Users of applyMergedLocation (all of these use GenerateLocation = true, now):

lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp
lib/Transforms/InstCombine/InstCombinePHI.cpp
lib/Transforms/Utils/PromoteMemoryToRegister.cpp
lib/Transforms/Utils/SimplifyCFG.cpp

Users of DILocation::getMergedLocation (all of these use GenerateLocation = false):

lib/CodeGen/BranchFolding.cpp
lib/CodeGen/MachineBasicBlock.cpp
lib/CodeGen/MachineSink.cpp
lib/Transforms/Scalar/ConstantHoisting.cpp


https://reviews.llvm.org/D45396