[PATCH] D45462: Add missing nullptr check before getSection() to AArch64MachObjectWriter::recordRelocation

Tue Apr 10 11:04:40 PDT 2018

Seemingly not (Debug+Assert):

FAIL: LLVM :: MC/AArch64/arm64-no-section.ll (31337 of 38754)
******************** TEST 'LLVM :: MC/AArch64/arm64-no-section.ll' FAILED ********************
Script:
--
not /home/dave/s/lc/d/bin/llc -mtriple=aarch64-darwin-- -filetype=obj /home/dave/s/lc/test/MC/AArch64/arm64-no-section.ll -o /dev/null
--
Exit Code: 1

Command Output (stderr):
--
This constant variable should have been expanded during evaluation
UNREACHABLE executed at ../lib/Target/AArch64/MCTargetDesc/AArch64MachObjectWriter.cpp:358!
#0 0x0000000003964329 llvm::sys::PrintStackTrace(llvm::raw_ostream&) /home/dave/s/lc/d/../lib/Support/Unix/Signals.inc:398:11
#1 0x0000000003964549 PrintStackTraceSignalHandler(void*) /home/dave/s/lc/d/../lib/Support/Unix/Signals.inc:462:1
#2 0x00000000039613f7 llvm::sys::RunSignalHandlers() /home/dave/s/lc/d/../lib/Support/Signals.cpp:0:5
#3 0x0000000003964900 SignalHandler(int) /home/dave/s/lc/d/../lib/Support/Unix/Signals.inc:252:1
#4 0x00007f4a68ac8fb0 __restore_rt (/lib64/libpthread.so.0+0x11fb0)
#5 0x00007f4a6743ef4b __GI_raise (/lib64/libc.so.6+0x36f4b)
#6 0x00007f4a67429591 __GI_abort (/lib64/libc.so.6+0x21591)
#7 0x00000000038340f0 llvm::install_out_of_memory_new_handler() /home/dave/s/lc/d/../lib/Support/ErrorHandling.cpp:193:0
#8 0x0000000001f0e457 (anonymous namespace)::AArch64MachObjectWriter::recordRelocation(llvm::MachObjectWriter*, llvm::MCAssembler&, llvm::MCAsmLayout const&, llvm::MCFragment const*, llvm::MCFixup const&, llvm::MCValue, unsigned long&) /home/dave/s/lc/d/../lib/Target/AArch64/MCTargetDesc/AArch64MachObjectWriter.cpp:0:7
#9 0x0000000002fdbd89 llvm::MachObjectWriter::recordRelocation(llvm::MCAssembler&, llvm::MCAsmLayout const&, llvm::MCFragment const*, llvm::MCFixup const&, llvm::MCValue, unsigned long&) /home/dave/s/lc/d/../lib/MC/MachObjectWriter.cpp:455:1
#10 0x0000000002f3ca00 llvm::MCAssembler::handleFixup(llvm::MCAsmLayout const&, llvm::MCFragment&, llvm::MCFixup const&) /home/dave/s/lc/d/../lib/MC/MCAssembler.cpp:0:17
#11 0x0000000002f3d478 llvm::MCAssembler::layout(llvm::MCAsmLayout&) /home/dave/s/lc/d/../lib/MC/MCAssembler.cpp:766:13
#12 0x0000000002f3db03 llvm::MCAssembler::Finish() /home/dave/s/lc/d/../lib/MC/MCAssembler.cpp:779:21
#13 0x0000000002fbbbcf llvm::MCObjectStreamer::FinishImpl() /home/dave/s/lc/d/../lib/MC/MCObjectStreamer.cpp:645:1
#14 0x0000000002fa7d6e (anonymous namespace)::MCMachOStreamer::FinishImpl() /home/dave/s/lc/d/../lib/MC/MCMachOStreamer.cpp:484:1
#15 0x0000000002fca09a llvm::MCStreamer::Finish() /home/dave/s/lc/d/../lib/MC/MCStreamer.cpp:842:1
#16 0x00000000023df764 llvm::AsmPrinter::doFinalization(llvm::Module&) /home/dave/s/lc/d/../lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1509:3
#17 0x0000000002e04a51 llvm::FPPassManager::doFinalization(llvm::Module&) /home/dave/s/lc/d/../lib/IR/LegacyPassManager.cpp:1559:16
#18 0x0000000002e05c90 (anonymous namespace)::MPPassManager::runOnModule(llvm::Module&) /home/dave/s/lc/d/../lib/IR/LegacyPassManager.cpp:1615:16
#19 0x0000000002e04be3 llvm::legacy::PassManagerImpl::run(llvm::Module&) /home/dave/s/lc/d/../lib/IR/LegacyPassManager.cpp:1700:16
#20 0x0000000002e06241 llvm::legacy::PassManager::run(llvm::Module&) /home/dave/s/lc/d/../lib/IR/LegacyPassManager.cpp:1731:3
#21 0x00000000016e954f compileModule(char**, llvm::LLVMContext&) /home/dave/s/lc/d/../tools/llc/llc.cpp:577:41
#22 0x00000000016e46a5 main /home/dave/s/lc/d/../tools/llc/llc.cpp:347:13
#23 0x00007f4a6742b1bb __libc_start_main (/lib64/libc.so.6+0x231bb)
#24 0x00000000016e302a _start (/home/dave/s/lc/d/bin/llc+0x16e302a)
Stack dump:
0.	Program arguments: /home/dave/s/lc/d/bin/llc -mtriple=aarch64-darwin-- -filetype=obj /home/dave/s/lc/test/MC/AArch64/arm64-no-section.ll -o /dev/null 
Error: Aborted

--

********************
Testing Time: 80.12s
********************
Failing Tests (1):
    LLVM :: MC/AArch64/arm64-no-section.ll

  Expected Passes    : 30591
  Expected Failures  : 83
  Unsupported Tests  : 8079
  Unexpected Failures: 1

> On Apr 10, 2018, at 13:39, Jessica Paquette <jpaquette at apple.com> wrote:
> 
> I think (hope) r329723 should fix it…
> 
> - Jessica
> 
>> On Apr 10, 2018, at 10:15 AM, David Zarzycki via Phabricator <reviews at reviews.llvm.org> wrote:
>> 
>> davezarzycki added a comment.
>> 
>> FYI – This test fails on my machine (Release+Assert):
>> 
>> FAIL: LLVM :: MC/AArch64/arm64-no-section.ll (28812 of 38754)
>> ******************** TEST 'LLVM :: MC/AArch64/arm64-no-section.ll' FAILED ********************
>> Script:
>> --
>> /tmp/_update_lc_t/bin/llc -mtriple=aarch64-darwin-- -filetype=obj /home/dave/s/lc/test/MC/AArch64/arm64-no-section.ll -o -
>> --
>> Exit Code: 134
>> 
>> Command Output (stderr):
>> --
>> This constant variable should have been expanded during evaluation
>> UNREACHABLE executed at /home/dave/s/lc/lib/Target/AArch64/MCTargetDesc/AArch64MachObjectWriter.cpp:358!
>> #0 0x0000000002033b7f llvm::sys::PrintStackTrace(llvm::raw_ostream&) (/tmp/_update_lc_t/bin/llc+0x2033b7f)
>> #1 0x0000000002033e86 SignalHandler(int) (/tmp/_update_lc_t/bin/llc+0x2033e86)
>> #2 0x00007ff9049d0fb0 __restore_rt (/lib64/libpthread.so.0+0x11fb0)
>> #3 0x00007ff903346f4b __GI_raise (/lib64/libc.so.6+0x36f4b)
>> #4 0x00007ff903331591 __GI_abort (/lib64/libc.so.6+0x21591)
>> #5 0x0000000001fde378 (/tmp/_update_lc_t/bin/llc+0x1fde378)
>> #6 0x00000000013869aa (anonymous namespace)::AArch64MachObjectWriter::recordRelocation(llvm::MachObjectWriter*, llvm::MCAssembler&, llvm::MCAsmLayout const&, llvm::MCFragment const*, llvm::MCFixup const&, llvm::MCValue, unsigned long&) (/tmp/_update_lc_t/bin/llc+0x13869aa)
>> #7 0x0000000001b23223 llvm::MachObjectWriter::recordRelocation(llvm::MCAssembler&, llvm::MCAsmLayout const&, llvm::MCFragment const*, llvm::MCFixup const&, llvm::MCValue, unsigned long&) (/tmp/_update_lc_t/bin/llc+0x1b23223)
>> #8 0x0000000001aed865 llvm::MCAssembler::layout(llvm::MCAsmLayout&) (/tmp/_update_lc_t/bin/llc+0x1aed865)
>> #9 0x0000000001aedb4b llvm::MCAssembler::Finish() (/tmp/_update_lc_t/bin/llc+0x1aedb4b)
>> #10 0x0000000001b0cd2f (anonymous namespace)::MCMachOStreamer::FinishImpl() (/tmp/_update_lc_t/bin/llc+0x1b0cd2f)
>> #11 0x00000000015c8394 llvm::AsmPrinter::doFinalization(llvm::Module&) (/tmp/_update_lc_t/bin/llc+0x15c8394)
>> #12 0x0000000001a7086f llvm::FPPassManager::doFinalization(llvm::Module&) (/tmp/_update_lc_t/bin/llc+0x1a7086f)
>> #13 0x0000000001a70de0 llvm::legacy::PassManagerImpl::run(llvm::Module&) (/tmp/_update_lc_t/bin/llc+0x1a70de0)
>> #14 0x0000000000ff99d7 compileModule(char**, llvm::LLVMContext&) (/tmp/_update_lc_t/bin/llc+0xff99d7)
>> #15 0x0000000000ff70bb main (/tmp/_update_lc_t/bin/llc+0xff70bb)
>> #16 0x00007ff9033331bb __libc_start_main (/lib64/libc.so.6+0x231bb)
>> #17 0x0000000000ff602a _start (/tmp/_update_lc_t/bin/llc+0xff602a)
>> Stack dump:
>> 0.      Program arguments: /tmp/_update_lc_t/bin/llc -mtriple=aarch64-darwin-- -filetype=obj /home/dave/s/lc/test/MC/AArch64/arm64-no-section.ll -o - 
>> /tmp/_update_lc_t/test/MC/AArch64/Output/arm64-no-section.ll.script: line 1: 274231 Aborted                 /tmp/_update_lc_t/bin/llc -mtriple=aarch64-darwin-- -filetype=obj /home/dave/s/lc/test/MC/AArch64/arm64-no-section.ll -o -
>> 
>> --
>> 
>> 
>> https://reviews.llvm.org/D45462
>> 
>> 
>> 
> 