[llvm] r329728 - Revert 329716 "Add missing nullptr check before getSection() to AArch64MachObjectWriter::recordRelocation"

[Jessica Paquette via llvm-commits]

Author: paquette
Date: Tue Apr 10 10:53:41 2018
New Revision: 329728

URL: http://llvm.org/viewvc/llvm-project?rev=329728&view=rev
Log:
Revert 329716 "Add missing nullptr check before getSection() to AArch64MachObjectWriter::recordRelocation"

This broke a bunch of bots so I'm reverting while I figure it out.


Removed:
    llvm/trunk/test/MC/AArch64/arm64-no-section.ll
Modified:
    llvm/trunk/lib/Target/AArch64/MCTargetDesc/AArch64MachObjectWriter.cpp

Modified: llvm/trunk/lib/Target/AArch64/MCTargetDesc/AArch64MachObjectWriter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/MCTargetDesc/AArch64MachObjectWriter.cpp?rev=329728&r1=329727&r2=329728&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AArch64/MCTargetDesc/AArch64MachObjectWriter.cpp (original)
+++ llvm/trunk/lib/Target/AArch64/MCTargetDesc/AArch64MachObjectWriter.cpp Tue Apr 10 10:53:41 2018
@@ -305,8 +305,7 @@ void AArch64MachObjectWriter::recordRelo
 
     bool CanUseLocalRelocation =
         canUseLocalRelocation(Section, *Symbol, Log2Size);
-    if (Symbol->isTemporary() && Symbol->isInSection() &&
-        (Value || !CanUseLocalRelocation)) {
+    if (Symbol->isTemporary() && (Value || !CanUseLocalRelocation)) {
       const MCSection &Sec = Symbol->getSection();
       if (!Asm.getContext().getAsmInfo()->isSectionAtomizableBySymbols(Sec))
         Symbol->setUsedInReloc();

Removed: llvm/trunk/test/MC/AArch64/arm64-no-section.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/AArch64/arm64-no-section.ll?rev=329727&view=auto
==============================================================================
--- llvm/trunk/test/MC/AArch64/arm64-no-section.ll (original)
+++ llvm/trunk/test/MC/AArch64/arm64-no-section.ll (removed)
@@ -1,10 +0,0 @@
-; RUN: not llc -mtriple=aarch64-darwin-- -filetype=obj %s -o /dev/null
-; CHECK: <inline asm>:1:2: error: unsupported relocation of local symbol
-; CHECK-SAME: 'L_foo_end'. Must have non-local symbol earlier in section.
-
-; Make sure that we emit an error when we try to reference something that
-; doesn't belong to a section.
-define void @foo() local_unnamed_addr {
-  call void asm sideeffect "b L_foo_end\0A", ""()
-  ret void
-}