[PATCH] D45210: [New-PM] Lift Scop Pipeline to CGSCC-level

[Lukas Böhm via Phabricator via llvm-commits]

lksbhm marked 3 inline comments as done.
lksbhm added inline comments.


================
Comment at: test/Isl/CodeGen/loop_with_condition_nested.ll:226
+
+; LOOPS:        Loop at depth 1 containing: %polly.loop_header<header>,%polly.cond,%polly.else,%polly.cond3,%polly.else6,%polly.then5,%polly.stmt.bb6,%polly.merge4,%polly.then,%polly.stmt.bb7,%polly.merge,%polly.stmt.bb9<latch><exiting>
+; LOOPS:        Loop at depth 1 containing: %bb1<header><exiting>,%bb2,%bb4,%bb7,%bb6,%bb8,%bb9,%bb10<latch>
----------------
The BasicBlock order is different in new-pm it seems. So that's why we need to duplicate this


================
Comment at: test/Isl/CodeGen/perf_monitoring_trip_counts_per_scop.ll:68
+; CHECK-DAG: @"__polly_perf_in_f_from__%next__to__%polly.merge_new_and_old_trip_count" = weak thread_local(initialexec) constant i64 0
+; CHECK-DAG: @"__polly_perf_in_g_from__%next__to__%polly.merge_new_and_old_trip_count" = weak thread_local(initialexec) constant i64 0
 
----------------
Globals are printed in a different order as well


================
Comment at: test/ScopInfo/aliasing_with_non_affine_access.ll:15
 ; Make sure we generate the correct aliasing check for a fixed-size memset operation.
-; CHECK: if (1 && (&MemRef_tmp0[15] <= &MemRef_tmp1[0] || &MemRef_tmp1[32] <= &MemRef_tmp0[14]))
+; TEST1-LABEL: :: isl ast :: test1 ::
+; TEST1-NEXT: {{^$}}
----------------
Function iteration order on cgscc level is also different sometimes. Should make sense to have a different run for each test anyways


Repository:
  rPLO Polly

https://reviews.llvm.org/D45210