[PATCH] D45445: [CodeGen/AccelTable] Add the "sizetype" synthetic type to the accelerator table

[Pavel Labath via Phabricator via llvm-commits]

labath updated this revision to Diff 141820.
labath added a comment.

I don't think repurpusing the __SIZE_TYPE__ name is a good idea, because it may
give off the impression that this type *is* the compiler's __SIZE_TYPE__ type,
but in reality, we don't even try to match it's definition. Also, right now the
compiler's __SIZE_TYPE__ does not seem to make it into debug info, but if that
ever changes, then we will have the multiple definition problem again.

So I think this should be really unique. Right now, the best name I came up with
is __ARRAY_SIZE_TYPE__.


Repository:
  rL LLVM

https://reviews.llvm.org/D45445

Files:
  lib/CodeGen/AsmPrinter/DwarfUnit.cpp
  test/DebugInfo/Generic/debug-names-index-type.ll
  test/DebugInfo/X86/nondefault-subrange-array.ll
  test/DebugInfo/X86/vla-dependencies.ll
  test/DebugInfo/X86/vla-global.ll
  test/DebugInfo/X86/vla-multi.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45445.141820.patch
Type: text/x-patch
Size: 6501 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180410/4847327c/attachment.bin>