[PATCH] D45428: [AArch64][AsmParser] Split index parsing from vector list.

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 10 01:45:09 PDT 2018


sdesmalen added inline comments.


================
Comment at: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:2963
+/// parseNeonVectorList - Parse a vector list operand for AdvSIMD instructions.
+bool AArch64AsmParser::parseNeonVectorList(OperandVector &Operands) {
+  if (tryParseVectorList(Operands))
----------------
rengolin wrote:
> This function doesn't look NEON specific, why the name change?
This is because matching the trailing index operand after a vector list is not used for SVE, so this patch makes the parseVectorList function generic and adds the index-operand parsing (Neon-specific) to parseNeonVectorList.


https://reviews.llvm.org/D45428





More information about the llvm-commits mailing list