[PATCH] D45467: COFF: Friendlier undefined symbol errors.

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 9 19:27:38 PDT 2018


zturner added a comment.

In https://reviews.llvm.org/D45467#1062612, @smeenai wrote:

> In https://reviews.llvm.org/D45467#1062522, @zturner wrote:
>
> > I just noticed you said on non-Windows.  Yea, I think the path should be whatever is native to the host you're building on.
>
>
> We cross-compile for Windows on Linux. If there's a change here, it would be awesome if I was CC'd, so I could test it with our setup and make sure VS and WinDbg are still happy.


Cross compiling is a weird situation here, because the paths aren't going to make sense anyway (obviously you can't run your debugger on the same machine that the program was built on in that setup, therefore any paths in the PDB are necessarily going to be useless).  So I think this should be a property of the machine you're building on (since that's the machine the source resides on, which is what the paths refer to), and have nothing to do with the target.


https://reviews.llvm.org/D45467





More information about the llvm-commits mailing list