[llvm] r329258 - [MIR-Canon] Fixing warnings in Non-assert builds.

[Puyan Lotfi via llvm-commits]

Yep, I am the only author at the moment and the file is pretty new is why I propose it.

PL

Sent with [ProtonMail](https://protonmail.com) Secure Email.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On April 9, 2018 7:12 PM, David Blaikie via llvm-commits <llvm-commits at lists.llvm.org> wrote:

> It's usually best to avoid formatting a whole file if you can help it  - as it can complicate the revision history a bit. But if a file is way out of format & you're about to do a bunch of work on it (such that your new, well formatted code would be out of place in the otherwise misformatted file), or you're the only author & the file is relatively new, it can be worthwhile/the right way to go.
>
> On Mon, Apr 9, 2018 at 7:10 PM Puyan Lotfi <puyan at puyan.org> wrote:
>
>> Ah, sorry this was a quick change to quite some unfortunate Release mode warnings. I'll probably do a whole commit just to run clang-format on the whole file. Thanks for the heads up.
>>
>> PL
>>
>> Sent with [ProtonMail](https://protonmail.com) Secure Email.
>>
>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>> On April 9, 2018 11:20 AM, David Blaikie <dblaikie at gmail.com> wrote:
>>
>>> Probably best to run code changes through clang-format, which I think would put these two statements on separate lines.
>>>
>>> On Wed, Apr 4, 2018 at 11:59 PM Puyan Lotfi via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>>>
>>>> Author: zer0
>>>> Date: Wed Apr  4 23:56:44 2018
>>>> New Revision: 329258
>>>>
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=329258&view=rev
>>>> Log:
>>>> [MIR-Canon] Fixing warnings in Non-assert builds.
>>>>
>>>> Modified:
>>>>     llvm/trunk/lib/CodeGen/MIRCanonicalizerPass.cpp
>>>>
>>>> Modified: llvm/trunk/lib/CodeGen/MIRCanonicalizerPass.cpp
>>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/MIRCanonicalizerPass.cpp?rev=329258&r1=329257&r2=329258&view=diff
>>>> ==============================================================================
>>>> --- llvm/trunk/lib/CodeGen/MIRCanonicalizerPass.cpp (original)
>>>> +++ llvm/trunk/lib/CodeGen/MIRCanonicalizerPass.cpp Wed Apr  4 23:56:44 2018
>>>> @@ -484,7 +484,7 @@ GetVRegRenameMap(const std::vector<Typed
>>>>        // (especially when comparing SelectionDAG to GlobalISel generated MIR)
>>>>        // that in the other file we are just getting an incoming vreg that comes
>>>>        // from a copy from a frame index. So it's safe to skip by one.
>>>> -      unsigned LastRenameReg = NVC.incrementVirtualVReg();
>>>> +      unsigned LastRenameReg = NVC.incrementVirtualVReg(); (void)LastRenameReg;
>>>>        DEBUG(dbgs() << "Skipping rename for FI " << LastRenameReg << "\n";);
>>>>        continue;
>>>>      } else if (vreg.isCandidate()) {
>>>> @@ -500,7 +500,7 @@ GetVRegRenameMap(const std::vector<Typed
>>>>        FirstCandidate = false;
>>>>        continue;
>>>>      } else if (!TargetRegisterInfo::isVirtualRegister(vreg.getReg())) {
>>>> -      unsigned LastRenameReg = NVC.incrementVirtualVReg();
>>>> +      unsigned LastRenameReg = NVC.incrementVirtualVReg(); (void)LastRenameReg;
>>>>        DEBUG({
>>>>          dbgs() << "Skipping rename for Phys Reg " << LastRenameReg << "\n";
>>>>        });
>>>>
>>>> _______________________________________________
>>>> llvm-commits mailing list
>>>> llvm-commits at lists.llvm.org
>>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180409/76ee175c/attachment.html>