[PATCH] D45265: [PowerPC] Replace the Post RA List Scheduler with the Machine Scheduler

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 9 16:11:48 PDT 2018


nemanjai requested changes to this revision.
nemanjai added a comment.
This revision now requires changes to proceed.

I'm afraid we can't just do this without doing some more testing. This patch will indiscriminately replace the existing Post-RA scheduler for all PowerPC targets, yet we've only tested it on Power9.

We need to do one of two things:

- Do some more thorough testing to make sure this doesn't adversely affect at least the CPU's we know are in the field (Power7/8, A2, ??)
- Make this a decision that is based on the target CPU and thereby dependent on the function. I'm not sure how we'd actually accomplish this though. Perhaps if it's reasonable, we could schedule a pass that will `getAnalysisIfAvailable<TargetPassConfig>()` and then call `substitutePass()` based on the CPU - although this is just guesswork and I'm not sure if it would work.


https://reviews.llvm.org/D45265





More information about the llvm-commits mailing list