[PATCH] D45345: [annotated_builder] try harder to clean build directories

Bob Haarman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 9 16:01:05 PDT 2018


inglorion added a comment.

Ah, my bad. Thanks for clarifying, @zturner.

@amccarth, point about possible incorrect directory tree removal semantics well taken, but I'd still like to ship this change as-is if that's ok with you. The reason is that it fixes a problem that is currently causing essentially every build to fail. Hopefully zturner is right and shutil actually does the right thing on Windows, and if not, I'll be happy to cook up a new patch if we find out it's causing problems.


https://reviews.llvm.org/D45345





More information about the llvm-commits mailing list