[PATCH] D45345: [annotated_builder] try harder to clean build directories

[Zachary Turner via llvm-commits]

I was talking about Adrian’s comment. I know it won’t clear the read only
flag, but Adrian’s comment was about something different.

I don’t think it’s worth the trouble doing anything better though, let the
OS handle it to the best of its ability (which your patch does)
On Mon, Apr 9, 2018 at 3:10 PM Bob Haarman via Phabricator <
reviews at reviews.llvm.org> wrote:

> inglorion added a comment.
>
> > Doesn't shutil.rmtree handle this?
>
> No. That's the code that's currently running. See here for the error:
> http://lab.llvm.org:8011/builders/clang-with-thin-lto-windows/builds/8570/steps/stage%202%20clean/logs/stdio
>
> I tested the code on the affected machine. shutil.rmtree fails with the
> permissions error. The rmtree implementation I wrote succeeds.
>
>
> https://reviews.llvm.org/D45345
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180409/1d6c9fd4/attachment.html>