[PATCH] D45138: [MC] Change std::sort to llvm::sort in response to r327219

Mandeep Singh Grang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 9 15:13:34 PDT 2018


mgrang added a comment.

In https://reviews.llvm.org/D45138#1062213, @ruiu wrote:

> I'm not familiar with r327219, but if a decision to use randomized sort has been made, why don't you replace all occurrences of std::sort with llvm::sort in a single patch? I don't think that an author of each file don't have to understand this kind of change and approve individually.


I had a patch to replace *all* occurrences of std::sort to llvm::sort https://reviews.llvm.org/D44363. However, the reviewers felt that the patch was getting too big and suggested splitting it into smaller patches target-wise, tablegen, MC, etc. Hence these separate patches.


Repository:
  rL LLVM

https://reviews.llvm.org/D45138





More information about the llvm-commits mailing list