[PATCH] D44928: [MC] Pass MCSubtargetInfo to fixupNeedsRelaxation and applyFixup

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 9 14:50:10 PDT 2018


efriedma added inline comments.


================
Comment at: include/llvm/MC/MCAsmBackend.h:83
   /// reported via \p Ctx.
+  /// The  \p STI is present only for fragments of type MCRelaxableFragment.
   virtual void applyFixup(const MCAssembler &Asm, const MCFixup &Fixup,
----------------
This comment needs to be updated?


================
Comment at: lib/MC/MCELFStreamer.cpp:90
   }
-  DF->setHasInstructions(true);
+  if (DF->getSubtargetInfo() == nullptr && EF->getSubtargetInfo())
+    DF->setHasInstructions(*EF->getSubtargetInfo());
----------------
Is it possible for these two subtargets to be different?


https://reviews.llvm.org/D44928





More information about the llvm-commits mailing list