[PATCH] D45325: [ELF] - Reorder local symbols.

Rafael Avila de Espindola via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 9 14:24:29 PDT 2018


espindola added a comment.

In https://reviews.llvm.org/D45325#1062280, @ruiu wrote:

> > Also, could we merge the partition and the sort?
>
> I thought the same thing, but I guess separating partition and sort is faster than merging them into one sort function call. Partition is O(n) and sort is O(n log n). So, IIUC, partitioning into local and global symbols first and then sorting only the local part should be faster than sorting the entire vector.


Sounds good. Lets keep both for now.


https://reviews.llvm.org/D45325





More information about the llvm-commits mailing list