[PATCH] D45303: shadowcallstack: Make runtime tests compatible with aarch64.

[Vlad Tsyrklevich via Phabricator via llvm-commits]

vlad.tsyrklevich added inline comments.


================
Comment at: compiler-rt/test/shadowcallstack/libc_support.h:24
+
+__attribute__((noinline)) void scs_fputs_stdout(const char *p) {
+  __asm__ __volatile__(
----------------
Attribute also belongs on the definition below


================
Comment at: compiler-rt/test/shadowcallstack/minimal_runtime.h:39
+
+  // We can't simply return scs_main() because scs_main might have corrupted our
+  // return address for testing purposes (see overflow.c), so we need to exit
----------------
Not sure I follow, if scs_main corrupted the RA don't we want to allow it to crash to satisfy the test? print_and_exit() also calls exit() directly so it shouldn't be required in that case.


https://reviews.llvm.org/D45303