[PATCH] D45436: [llvm-exegesis] Add a flag to disable libpfm even if present.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 9 09:38:09 PDT 2018


lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

I don't really know LLVM's buildsystem, but this looks about right to me.
Sidenote:



================
Comment at: cmake/config-ix.cmake:94
+if (LLVM_ENABLE_LIBPFM)
+  check_library_exists(pfm pfm_initialize "" HAVE_LIBPFM_INITIALIZE)
+  if(HAVE_LIBPFM_INITIALIZE)
----------------
Sidenote: **normally**, this should be in a `cmake/Modules/FindPFM.cmake`, and this should be just
```
if (LLVM_ENABLE_LIBPFM)
  find_package(PFM REQUIRED)
endif()
```



Repository:
  rL LLVM

https://reviews.llvm.org/D45436





More information about the llvm-commits mailing list