[PATCH] D40556: SIFixSGPRCopies should not change non-divergent PHI

Alexander Timofeev via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 9 04:37:13 PDT 2018


It seems like this patch should be reverted. Recently we have no reliable
way to determine the PHI (or whatever else) divergence on the MI level.
The only correct way is to add the DA algorithm that re-computes all the MI
divergence.
Since we're going to remove the SGPRFix stuff as soon as diverence driven
ISel is ready I consider this patch is not necessary.

On Sat, Mar 17, 2018 at 6:20 PM, Alexander via Phabricator <
reviews at reviews.llvm.org> wrote:

> alex-t added a comment.
>
> I m looking on this.
>
> 17 марта 2018 г. 3:27 PM пользователь "Nicolai Hähnle via Phabricator" <
> reviews at reviews.llvm.org> написал:
>
> > nhaehnle added a comment.
> >
> > Is this related to https://reviews.llvm.org/D40547? I sent a ping on
> >  that, but no response...
> >
> > Repository:
> >
> >   rL LLVM
> >
> > https://reviews.llvm.org/D40556
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D40556
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180409/ee7e61ac/attachment.html>


More information about the llvm-commits mailing list