[PATCH] D43876: [LoopUnroll] Peel off iterations if it makes conditions true/false.

Chad Rosier via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 6 12:49:29 PDT 2018


mcrosier added a comment.

In https://reviews.llvm.org/D43876#1060032, @efriedma wrote:

> > This is exactly the case we're dealing with here except FullPelBlockMotionBiPred isn't marked as internal until the LTO phase of compilation. Thus, one possible approach would be to defer peeling until the LTO phase. After r329392, this can be accomplished with a small change to the pass manager:
>
> ThinLTO doesn't run vectorization or unrolling before link-time; among other reasons, it avoids problems like this.  You might want to consider making non-thin LTO work the same way.


Thanks for the suggestion, Eli.  Given this is already the behavior of ThinLTO, I'm going to investigate this further.


Repository:
  rL LLVM

https://reviews.llvm.org/D43876





More information about the llvm-commits mailing list