[PATCH] D45378: [InstCombine] Propagate null values from conditions to other basic blocks

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 6 12:01:39 PDT 2018


xbolva00 added a comment.

In https://reviews.llvm.org/D45378#1060001, @lebedev.ri wrote:

> High-level question: what is this trying to do?
>  Can't you just use `ReplaceUsesOfWith()`, or something like that?


if (!ptr)

  return NULL;

replaces e.g. $null with $ptr in blocks where we know $ptr == $null.

I have to rework patch, since it should jump to "NullPtrBlock" (after cmp) and then check br instr a jump to next possible block. Now, it just iterates over blocks starting with  "NullPtrBlock".


Repository:
  rL LLVM

https://reviews.llvm.org/D45378





More information about the llvm-commits mailing list