[PATCH] D45360: [MC][TableGen] Add optional libpfm counter names for ProcResUnits.

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 6 06:36:37 PDT 2018


courbet added a comment.

In https://reviews.llvm.org/D45360#1059650, @andreadb wrote:

> In https://reviews.llvm.org/D45360#1059635, @RKSimon wrote:
>
> > I'm a bit worried about creating a pfm dependency like this in the core - pfm doesn't come close to covering all targets that we'll want to check in the long term so it's likely that some targets will require a different library. (or raw msrs.....)
> >
> > Is there anyway that we can keep more of this in llvm-exegesis project - config files or embedding in source?
>
>
> I tend to agree with Simon.
>  All of this info could live in a config file within exegesis. Something that describes the mapping between abstract counters for perf events and actual pfm counters.


If we were using raw events, I would agree. But the whole point of libpfm is to abstract counters.  libpfm pretty much *is* this mapping.


Repository:
  rL LLVM

https://reviews.llvm.org/D45360





More information about the llvm-commits mailing list