[PATCH] D45362: [IRCE] Relax restriction on collected range checks

[Sam Parker via Phabricator via llvm-commits]

samparker accepted this revision.
samparker added a comment.
This revision is now accepted and ready to land.

Hi Max,

LGTM with just one small nit, but its up to you.

I was playing with something very similar the week before last. For my example, I also needed to change the 'IsInductionVar' lamdba to use the NUW as well as NSW, is that valid? If so, I will get the patch up once this is in.

thanks.



================
Comment at: lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp:316
+  auto IsLoopInvariant = [&SE, L](Value *V) {
+    return SE.isLoopInvariant(SE.getSCEV(V), L);
   };
----------------
Do we really need a lambda for a single statement?


https://reviews.llvm.org/D45362