[PATCH] D36351: [lld][ELF] Add profile guided section layout

[Rafael Avila de Espindola via Phabricator via llvm-commits]

espindola added inline comments.


================
Comment at: ELF/CallGraphSort.cpp:56
+namespace {
+using SectionIndex = int32_t;
+using EdgeIndex = int32_t;
----------------
Bigcheese wrote:
> espindola wrote:
> > Delete these typedefs and just use the proper type directly.
> > 
> That would significantly reduce code clarity.  It's not uncommon in LLVM to do this.  LLD even has a case of this with Relocations.h RelType.
RelType is the one example in lld and its use spans most of the linker, so it makes sense there. This is completely local and is just noise. Delete it.


================
Comment at: ELF/Symbols.cpp:251
 
+void elf::warnUnorderableSymbol(const Symbol *Sym, const InputFile *File) {
+  if (!Config->WarnSymbolOrdering)
----------------
Rebase on top of r329371. You should be able to remove the File argument with that.


https://reviews.llvm.org/D36351