[PATCH] D45346: [LLVM-C] Audit Inline Assembly APIs for Consistency

[whitequark via Phabricator via llvm-commits]

whitequark requested changes to this revision.
whitequark added a comment.
This revision now requires changes to proceed.

Oh sorry, I've missed one API issue.



================
Comment at: include/llvm-c/Core.h:684
+LLVMValueRef LLVMGetInlineAsm(LLVMTypeRef Ty,
+                              char *AsmString, char *Constraints,
+                              LLVMBool HasSideEffects, LLVMBool IsAlignStack,
----------------
I think this should be `const char *AsmString, size_t AsmStringSize, const char *Constraints, size_t ConstraintsSize`.


https://reviews.llvm.org/D45346