style update, r328848

[George Karpenkov via llvm-commits]

Hi Rafael,

I’ve meant to say that it seems inconsistent to only rename those functions when many other classes in the codebase
have methods starting with EmitInt.
For example:

george@/Volumes/Transcend/code/llvm (master)≻ rg EmitInt8
lib/CodeGen/AsmPrinter/ByteStreamer.h
33:  virtual void EmitInt8(uint8_t Byte, const Twine &Comment = "") = 0;
44:  void EmitInt8(uint8_t Byte, const Twine &Comment) override {
63:  void EmitInt8(uint8_t Byte, const Twine &Comment) override {
89:  void EmitInt8(uint8_t Byte, const Twine &Comment) override {

lib/CodeGen/AsmPrinter/DwarfDebug.cpp
166:  BS.EmitInt8(
1665:    Streamer.EmitInt8(Byte, Comment != End ? *(Comment++) : "");

lib/Target/ARM/MCTargetDesc/ARMUnwindOpAsm.cpp
86:      EmitInt8(ARM::EHABI::UNWIND_OPCODE_POP_REG_RANGE_R4 | Range);
90:      EmitInt8(ARM::EHABI::UNWIND_OPCODE_POP_REG_RANGE_R4_R14 | Range);
129:  EmitInt8(ARM::EHABI::UNWIND_OPCODE_SET_VSP | Reg);
141:      EmitInt8(ARM::EHABI::UNWIND_OPCODE_INC_VSP | 0x3fu);
144:    EmitInt8(ARM::EHABI::UNWIND_OPCODE_INC_VSP |
148:      EmitInt8(ARM::EHABI::UNWIND_OPCODE_DEC_VSP | 0x3fu);
151:    EmitInt8(ARM::EHABI::UNWIND_OPCODE_DEC_VSP |

lib/Target/ARM/MCTargetDesc/ARMUnwindOpAsm.h
73:  void EmitInt8(unsigned Opcode) { 

Regards,
George

> On Apr 5, 2018, at 6:25 PM, Rafael Avila de Espindola <rafael.espindola at gmail.com> wrote:
> 
> I updated the documentation in r329368.
> 
> I am not sure what EmitIntX you are referring to.
> 
> Thanks,
> Rafael
> 
> George Karpenkov <ekarpenkov at apple.com> writes:
> 
>> Hi,
>> 
>> I’ve just looked at the change
>> https://github.com/llvm-mirror/llvm/commit/9f3889b501cedc1b9aeffcb8afd3100b45bb48e5
>> because we had a merge issue on an internal branch.
>> 
>> This makes the code inconsistent with the documentation (GarbageCollection.rst),
>> and EmitIntX (with an uppercase) is used in a couple more places.
>> Perhaps they all should be updated then?
>> 
>> George