[PATCH] D43907: [llvm-cov] Implement -ignore-source-regex= option for excluding source files.

[Vedant Kumar via Phabricator via llvm-commits]

vsk added inline comments.


================
Comment at: tools/llvm-cov/CodeCoverage.cpp:604
+  cl::list<std::string> IgnoreSourceRegexFilters(
+      "ignore-source-regex", cl::Optional,
+      cl::desc("Skip source code files with file paths that match the given "
----------------
For consistency with -name-regex, could we name this 'ignore-filename-regex' and drop the period at the end of the description?


================
Comment at: tools/llvm-cov/SourceFilters.h:23
+/// \brief Matches specific filename that pass the requirement of this filter.
+class SourceFilter {
+public:
----------------
Wdyt of implementing this by adding 'virtual bool matchesFilename(StringRef Filename)' to CoverageFilter? That should allow you to dedup some similar functionality as CoverageFilters already exists, etc. 


Repository:
  rL LLVM

https://reviews.llvm.org/D43907