[PATCH] D45329: [InstCombine] [NFC] Add more tests for getting rid of select of bittest (D45108, PR36950 / PR17564)

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: test/Transforms/InstCombine/select-of-bittest.ll:292
+
+define i32 @f_var2(i32, i32) {
+; CHECK-LABEL: @f_var2(
----------------
spatel wrote:
> lebedev.ri wrote:
> > spatel wrote:
> > > It's better for readability to give the params and other values names. You can use 'opt -instnamer' to do that.
> > Hmm, right. I shall use that for the future tests, thanks!
> > But i guess i better keep this test as-is.
> It's ok if you want to commit this as-is, but please do add the names and rebase D45108. No need to for pre-commit review for the test updating.
Is there some way to run the pass and not loose all the comments in the test?


Repository:
  rL LLVM

https://reviews.llvm.org/D45329