[PATCH] D45315: [X86] Improve unsigned saturation downconvert detection.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 5 09:41:49 PDT 2018


RKSimon added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:34572
+    if (MinOp.getOpcode() != ISD::SMAX)
+      return SDValue();
+
----------------
Don't you need to test both SMIN(SMAX(X, C1), C2) and SMAX(SMIN(X, C2), C1) - see detectSSatPattern


Repository:
  rL LLVM

https://reviews.llvm.org/D45315





More information about the llvm-commits mailing list