[PATCH] D44257: [MemorySSAUpdater] Mark non-trivial Phi for not to optimize

[Z. Zheng via Phabricator via llvm-commits]

zzheng marked 2 inline comments as done.
zzheng added a comment.

> Just one nit (inline) and a general question: is this new set meant to persist across multiple updates, should the `erase` in `fixupDefs` be taking care of everything added in a given query, or should we be clearing it at some point?

> (If the answer is "the middle one," would it be easy to assert that the def is empty somewhere?)

At least two GVN-hoist test cases need NonOptPhis be cleared. The patch is scoped at per call of MemorySSAUpdater::moveTo(), so clean-up is placed at the end of this function.


Repository:
  rL LLVM

https://reviews.llvm.org/D44257