[PATCH] D44780: [ELF] - Implement linker script OVERLAYs.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 4 14:37:38 PDT 2018


ruiu added inline comments.


================
Comment at: ELF/ScriptParser.cpp:725
+OutputSection *ScriptParser::readOutputSectionDescription(StringRef OutSec,
+                                                          bool InOverlay) {
   OutputSection *Cmd =
----------------
We shouldn't add a new parameter to this existing function for the minor feature. Please just remove it.


https://reviews.llvm.org/D44780





More information about the llvm-commits mailing list