[PATCH] D44257: [MemorySSAUpdater] Mark non-trivial Phi for not to optimize

[George Burgess IV via Phabricator via llvm-commits]

george.burgess.iv added a comment.

Thanks for the patch!

Just one nit (inline) and a general question: is this new set meant to persist across multiple updates, should the `erase` in `fixupDefs` be taking care of everything added in a given query, or should we be clearing it at some point?

(If the answer is "the middle one," would it be easy to assert that the def is empty somewhere?)

> Please commit the spelling corrections in lib/Analysis/MemorySSA.cpp separately

+1.



================
Comment at: lib/Analysis/MemorySSAUpdater.cpp:316
+    if (MemoryPhi *Phi = dyn_cast_or_null<MemoryPhi>(NewDef))
+      if (NonOptPhis.count(Phi))
+        NonOptPhis.erase(Phi);
----------------
Nit: Can the `count` check be removed entirely?


Repository:
  rL LLVM

https://reviews.llvm.org/D44257