[PATCH] D45260: COFF: Layout sections in the same order as link.exe

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 4 11:42:37 PDT 2018


hans added inline comments.


================
Comment at: COFF/Writer.cpp:661
+      .Case(".rsrc", INT_MAX - 1)
+      .Case(".reloc", INT_MAX)
+      .Default(INT_MAX / 2); // Default to somewhere in the middle.
----------------
hans wrote:
> pcc wrote:
> > Have you confirmed that UpdateResource updates the `.reloc` address in the data directory if it is moved?
> Let me check..
Yes it looks like it does (I compared Chromium's mini_installer.exe and next_version_mini_installer.exe)


https://reviews.llvm.org/D45260





More information about the llvm-commits mailing list