[PATCH] D45260: COFF: Layout sections in the same order as link.exe
    Rui Ueyama via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Wed Apr  4 11:26:46 PDT 2018
    
    
  
ruiu accepted this revision.
ruiu added a comment.
LGTM
================
Comment at: COFF/Writer.cpp:660-662
+      .Case(".rsrc", INT_MAX - 1)
+      .Case(".reloc", INT_MAX)
+      .Default(INT_MAX / 2); // Default to somewhere in the middle.
----------------
This is a nit but I'd perhaps use 99, 100 and 50 or something like that for these numbers instead of super large numbers.
https://reviews.llvm.org/D45260
    
    
More information about the llvm-commits
mailing list