[PATCH] D45252: [ELF] - X86_64: Use white list for relocations checked by isPicRel.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 4 08:24:30 PDT 2018


This revision was automatically updated to reflect the committed changes.
Closed by commit rL329203: [ELF] - X86_64: Use white list for relocations checked by isPicRel. (authored by grimar, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D45252?vs=140936&id=140963#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D45252

Files:
  lld/trunk/ELF/Arch/X86_64.cpp


Index: lld/trunk/ELF/Arch/X86_64.cpp
===================================================================
--- lld/trunk/ELF/Arch/X86_64.cpp
+++ lld/trunk/ELF/Arch/X86_64.cpp
@@ -156,9 +156,8 @@
 }
 
 template <class ELFT> bool X86_64<ELFT>::isPicRel(RelType Type) const {
-  return Type != R_X86_64_8 && Type != R_X86_64_PC8 && Type != R_X86_64_16 &&
-         Type != R_X86_64_PC16 && Type != R_X86_64_32 &&
-         Type != R_X86_64_PC32 && Type != R_X86_64_TPOFF32;
+  return Type == R_X86_64_64 || Type == R_X86_64_PC64 ||
+         Type == R_X86_64_SIZE32 || Type == R_X86_64_SIZE64;
 }
 
 template <class ELFT>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45252.140963.patch
Type: text/x-patch
Size: 617 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180404/e1c96a75/attachment.bin>


More information about the llvm-commits mailing list