[PATCH] D45195: Add --check-library-dependency to maintain compatibility with other linkers

[Rafael Avila de Espindola via Phabricator via llvm-commits]

espindola added a comment.

The option and general algorithm makes sense to me.

I am just not sure about the name since cyclic dependencies are still supported with --start-group/--end-group for example.

BTW, I think this is a conservative heuristic since it would warn on "foo.a --start-group bar.a foo.a --end-group" if bar.a fetches a member of foo.a. That is probably fine.

Taking a look at the implementation now.


https://reviews.llvm.org/D45195