[PATCH] D41062: [X86] Legalize v2i32 via widening rather than promoting

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 3 14:32:56 PDT 2018


craig.topper added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/TargetLowering.cpp:726
+    Known.Zero.setAllBits(); Known.One.setAllBits();
+    for (unsigned i = 0; i != Op.getNumOperands(); ++i) {
+      if (SimplifyDemandedBits(Op.getOperand(i), NewMask, Known2, TLO, Depth+1))
----------------
RKSimon wrote:
> convert to for-range loop or for (unsigned i = 0, e = Op.getNumOperands(); i != e; ++i) {
> 
> BTW - Can this diff be pulled out?
It doesn't change any test cases in the existing lit tests today.


https://reviews.llvm.org/D41062





More information about the llvm-commits mailing list