[PATCH] D44560: [DWARF] Rework debug line parsing to use llvm::Error and callbacks

[David Blaikie via llvm-commits]

I was picturing the parser being the thing that exposes the iterator - so
it would be an internal detail & wouldn't really warrant an extra Error
type - but I haven't thought about it too hard & maybe that doesn't make
sense?

On Tue, Apr 3, 2018 at 8:33 AM Jonas Devlieghere via Phabricator <
reviews at reviews.llvm.org> wrote:

> JDevlieghere added a comment.
>
> In https://reviews.llvm.org/D44560#1055708, @dblaikie wrote:
>
> > I'm still a bit undecided about new Error types here - I think exposing
> an
> >  iterator (or iterator-like thing) rather than special changes to the
> offset
> >  or an error kind the user checks to see whether to iterate might be
> better?
>
>
> I agree, but (unless I misunderstand) that's on another level, right? We'd
> still need to communicate from the parser whether we can parse the next LT,
> i.e. if there's going to be a next iterator?
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D44560
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180403/963812f3/attachment.html>