[PATCH] D44560: [DWARF] Rework debug line parsing to use llvm::Error and callbacks

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 3 08:27:15 PDT 2018


I'm still a bit undecided about new Error types here - I think exposing an
iterator (or iterator-like thing) rather than special changes to the offset
or an error kind the user checks to see whether to iterate might be better?

On Tue, Apr 3, 2018 at 8:00 AM Jonas Devlieghere via Phabricator <
reviews at reviews.llvm.org> wrote:

> JDevlieghere added a comment.
>
> I agree with @espindola, it makes more sense to have to have a separate
> error.
>
> In https://reviews.llvm.org/D44560#1049025, @jhenderson wrote:
>
> > No problem. I'm going to try experimenting with the context-based error
> handler a little in the meantime, and will upload another diff to present
> it, if I have enough time by the end of the week. FYI, I'm away on annual
> leave myself from Friday until Euro LLVM, so won't be reading emails until
> I'm back in the office (will you be around at the conference?).
>
>
> Yes, I look forward to meeting you!
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D44560
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180403/0c621204/attachment.html>


More information about the llvm-commits mailing list