[PATCH] D45130: [CallSiteSplitting] Do not perform callsite splitting inside landing pad

[Jun Bum Lim via Phabricator via llvm-commits]

junbuml added a comment.

Thanks for handling this. Just minor comments inlined.



================
Comment at: lib/Transforms/Scalar/CallSiteSplitting.cpp:217-220
+  if (CallSiteBB->isEHPad())
+    return false;
+
   return CallSiteBB->canSplitPredecessors();
----------------
Since canSplitPredecessors() simply return false for EHPad except LandingPad, you can return false for EHPad here like : 

   return !CallSiteBB->isEHPad();


================
Comment at: test/Transforms/CallSiteSplitting/lpad.ll:7
+; CHECK-LABEL: @caller
+; CHECK: call void @callee
+; CHECK-NOT: call void @callee
----------------
Could you please also check the basic block name ? 


Repository:
  rL LLVM

https://reviews.llvm.org/D45130