[PATCH] D45130: Do not perform callsite splitting inside landing pad

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 3 07:37:46 PDT 2018


fhahn added a comment.

In https://reviews.llvm.org/D45130#1055295, @twoh wrote:

> Thanks @fhahn for the comments! I added comments about why we don't perform splitting for the callsites inside the landing pad. Please let me know if you think it is too verbose.


Thanks. It is quite verbose and I think it would be enough to state that this check prevents triggering an assertion in SplitEdge used via DuplicateInstructionsInSplitBetween. It is fine to just update the comment before committing. Could you also prefix [CallSiteSplitting] to the commit message?


Repository:
  rL LLVM

https://reviews.llvm.org/D45130





More information about the llvm-commits mailing list