[PATCH] D44980: [MC][Tblgen] Allow the definition of processor register files in the scheduling model for llvm-mca

[Clement Courbet via Phabricator via llvm-commits]

courbet added inline comments.


================
Comment at: utils/TableGen/SubtargetEmitter.cpp:608
 
+void SubtargetEmitter::EmitExtraProcessorInfo(const CodeGenProcModel &ProcModel,
+                                              raw_ostream &OS) {
----------------
andreadb wrote:
> courbet wrote:
> > I'm wondering how hard it is to emit this information into a separate file ? As you mentioned in the diff description it would avoid this kind of changes impacting main llvm binaries size/compile time
> My naive idea was to still keep everything into a single file, and then (maybe as a future patch) have a flag to selectively disable the emission of the extra tables for specific cpus (or entire targets). It is still possible to strip symbols from the binary if we don't want them in the binary.
> To be honest, I didn't try to look into having two separate files. I guess, that can be a follow up?
I don't have a strong feeling, but I've seen size of static tables being raised as  a concern in previous reviews. This is only a couple hundred bytes, so I guess that's fine.


https://reviews.llvm.org/D44980