[PATCH] D44519: Add llvm-exegesis tool.

[Clement Courbet via Phabricator via llvm-commits]

courbet added a comment.

In https://reviews.llvm.org/D44519#1055446, @andreadb wrote:

> In https://reviews.llvm.org/D44519#1055440, @courbet wrote:
>
> > In https://reviews.llvm.org/D44519#1055406, @andreadb wrote:
> >
> > > The major problem I see is that the tool expects perf event "UNHALTED_CORE_CYCLES" to be always available. However, that event is Intel specific.
> > >  I tried to manually change it to something meaningful for my system. However, it would be really nice if we find a way to abstract "generic perf events".
> > >  For example, we could have the "generic cpu clock" event, which targets/subtargers can define as a alias for a specific hw event type. So, on Intel chips, that "generic cpu clock" event would be wired to UNHALTED_CORE_CYCLES. Is there a plan for doing it?
> >
> >
> > If you look at the code where the event is defined, there is a TODO to get the name of the event from the sched model (or resource Resource Unit for uops). Our plan is to add the name of the counters to use as an optional property of the SchedModel in TD files.
>
>
> Cool. Thanks! I like the idea :-).
>
> I don't have other problems with the tool.
>
> If you fix the TODO comments, then it looks good to me.


Great, thanks for the review Andrea !


Repository:
  rL LLVM

https://reviews.llvm.org/D44519