[PATCH] D45130: Do not perform callsite splitting inside landing pad

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

Thank you very much for your patch. Using DuplicateInstructionsInSplitBetween here has surfaced a few edge cases already.

LGTM



================
Comment at: lib/Transforms/Scalar/CallSiteSplitting.cpp:209
 
+  // Do not split a call-site in a landing pad.
+  if (CallSiteBB->isEHPad())
----------------
Is there any reason besides the duplicateInstructionsInSplitBetween, that prevents us from splitting the callsite? It would be great if you could mention why we cannot do splitting here.


================
Comment at: test/Transforms/CallSiteSplitting/lpad.ll:1
+; RUN: opt -S -callsite-splitting < %s
+
----------------
junbuml wrote:
> Can you add FileCheck to check no callsite splitting happened ? 
Could you also check that there is only on call to callee? Checking for not split is slightly more fragile.


Repository:
  rL LLVM

https://reviews.llvm.org/D45130