[PATCH] D44780: [ELF] - Implement linker script OVERLAYs.

Rafael Avila de Espindola via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 2 12:44:51 PDT 2018


espindola added inline comments.


================
Comment at: ELF/ScriptParser.cpp:433
+static std::vector<BaseCommand *>
+createStartStopSymbols(ArrayRef<BaseCommand *> V, std::string Loc) {
+  // This crafts start/stop symbols. Names of such symbols are produced
----------------
Can't we create these symbols in the existing addStartStopSymbols function?

I might be a good idea to leave the symbols for a followup patch.


https://reviews.llvm.org/D44780





More information about the llvm-commits mailing list