[PATCH] D41827: [DEBUG] Initial adaptation of NVPTX target for debug info emission.

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: lib/Target/NVPTX/NVPTXAsmPrinter.cpp:477
+  // Emit open brace for function body.
   OutStreamer->EmitRawText(StringRef("{\n"));
   setAndEmitFunctionVirtualRegisters(*MF);
----------------
ABataev wrote:
> echristo wrote:
> > tra wrote:
> > > Please add a comment here that the closing brace is emitted at the end of NVPTXAsmPrinter::runOnMacheineFunction(). 
> > Seems odd that we're pulling the functionality across multiple functions that don't really work in pairs. 
> Yes, maybe it is worth it to add some option that allows enclosing of the dwarf sections into braces on the emission?
Ahh, no, it won't work. This is caused by the fact that we only perform switch to section but not doing exit from the section emission. Because of that we just can't form pair of functions to emit braces


Repository:
  rL LLVM

https://reviews.llvm.org/D41827