[PATCH] D45130: Do not perform callsite splitting inside landing pad

Jun Bum Lim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 2 08:36:18 PDT 2018


junbuml added inline comments.


================
Comment at: lib/Transforms/Scalar/CallSiteSplitting.cpp:486-487
         continue;
+      if (I->getParent()->isEHPad())
+        continue;
 
----------------
junbuml wrote:
> Can you move this check in canSplitCallSite()? You can use !CallSiteBB->isEHPad() instead of CallSiteBB->canSplitPredecessors() in line 216.
> 
Please see line 209 instead of line 216.


Repository:
  rL LLVM

https://reviews.llvm.org/D45130





More information about the llvm-commits mailing list