[PATCH] D45159: [ELF] - Fix cref.s test case.

[George Rimar via Phabricator via llvm-commits]

grimar created this revision.
grimar added a reviewer: ruiu.
Herald added subscribers: arichardson, emaste.

It seems to me that the intention of -gc-sections flag was to check
that `discarded` is not in the output. And if so it should be
specified in the executable command line invocation and
also, the symbol must be global as local symbols are anyways
not printed.


https://reviews.llvm.org/D45159

Files:
  test/ELF/cref.s


Index: test/ELF/cref.s
===================================================================
--- test/ELF/cref.s
+++ test/ELF/cref.s
@@ -3,8 +3,8 @@
 // RUN: echo '.global foo; foo:' | llvm-mc -filetype=obj -triple=x86_64-pc-linux - -o %t1.o
 // RUN: echo '.global foo, bar; bar:' | llvm-mc -filetype=obj -triple=x86_64-pc-linux - -o %t2.o
 // RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t3.o
-// RUN: ld.lld -shared -o %t1.so %t1.o -gc-sections
-// RUN: ld.lld -o /dev/null %t1.so %t2.o %t3.o -cref | FileCheck -strict-whitespace %s
+// RUN: ld.lld -shared -o %t1.so %t1.o
+// RUN: ld.lld -o /dev/null %t1.so %t2.o %t3.o -gc-sections -cref | FileCheck -strict-whitespace %s
 
 //      CHECK: Symbol                                            File
 // CHECK-NEXT: bar                                               {{.*}}2.o
@@ -14,8 +14,9 @@
 // CHECK-NEXT:                                                   {{.*}}3.o
 // CHECK-NEXT: _start                                            {{.*}}3.o
 // CHECK-NEXT: baz                                               {{.*}}3.o
+// CHECK-NOT:  discarded
 
-.global _start, foo, bar, baz
+.global _start, foo, bar, baz, discarded
 _start:
   call foo
   call bar


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45159.140614.patch
Type: text/x-patch
Size: 1216 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180402/2fa0808a/attachment.bin>